Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[feature]: CMS pages should display Content Heading and update page title in <head> to reflect the page that a user is on #2158

Closed
2 tasks done
luke-denton-aligent opened this issue Feb 11, 2020 · 1 comment · Fixed by #2159
Assignees
Labels
enhancement New feature or request

Comments

@luke-denton-aligent
Copy link
Contributor

Is your feature request related to a problem? Please describe.
I've created a new page using Page Builder, and loaded it through PWA Studio. I notice that Content Heading that I've set in the admin isn't displayed anywhere in the app. In Luma, this is displayed, so I would assume we'd want to retain that feature? Similarly, the title displayed in the browser tab remains as "Home Page - Venia", which is incorrect. Please see image below, the page being displayed is "About Us", but there is no way of knowing that.

image

Describe the solution you'd like
I'd like to see the title displayed in the tab update to match the title of the CMS page that I'm viewing, and to have the Content Heading displayed as a title on the page, so it's consistent with the data that is displayed on a Luma CMS page. Please see the simple update I've made below, that will update the document title to be cmsPage.title, and add the cmsPage.content_heading to the output, using a h1

image

Describe alternatives you've considered
Not updating the title nor displaying the content heading - I can possibly understand not displaying the content heading, but in that case we should update the admin to remove that input field, as I believe it then serves no purpose. The tab title should definitely be updated

Please let us know what packages this feature is in regards to:

  • venia-concept
  • venia-ui
@awilcoxa
Copy link

awilcoxa commented Mar 9, 2020

Created in Jira backlog (PWA-383). During grooming team discussed that this needs additional research spike and currently marked as Priority 3.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants