Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[bug]: Pagination div active it's outside #2296

Closed
7 tasks
RicardoHds opened this issue Mar 31, 2020 · 5 comments
Closed
7 tasks

[bug]: Pagination div active it's outside #2296

RicardoHds opened this issue Mar 31, 2020 · 5 comments
Labels
bug Something isn't working

Comments

@RicardoHds
Copy link

Describe the bug
Pagination component add an div when current page it's active, but the number it's outside of this div.

To reproduce
All paginator shows the same error.

Expected behavior
For a better manipulation the number should be inside of div with the classname "title.

Screenshots
Capture

Additional context
Add any other context about the problem here.

Possible solutions
Get number like a prop inside of marker div.

Please complete the following device information:

  • Device [e.g. iPhone6, PC, Mac, Pixel3]:
  • OS [e.g. iOS8.1, Windows 10]:
  • Browser [e.g. Chrome, Safari]:
  • Browser Version [e.g. 22]:
  • Magento Version:
  • PWA Studio Version:
  • NPM version npm -v:
  • Node Version node -v:

Please let us know what packages this bug is in regards to:

  • venia-concept
  • venia-ui
  • pwa-buildpack
  • peregrine
  • pwa-devdocs
  • upward-js
  • upward-spec
  • create-pwa
@RicardoHds RicardoHds added the bug Something isn't working label Mar 31, 2020
@LucasCalazans
Copy link
Member

@RicardoHds I could not reproduce this issue.

image
image

I'm running a clone of this repository.

Is it in the category page or in another one?

@awilcoxa
Copy link

awilcoxa commented Apr 7, 2020

created in Jira backlog for triage.

@awilcoxa
Copy link

awilcoxa commented Apr 9, 2020

This issue should be resolved in latest develop

@awilcoxa
Copy link

awilcoxa commented Apr 9, 2020

Closing as resolved

@awilcoxa awilcoxa closed this as completed Apr 9, 2020
@awilcoxa
Copy link

awilcoxa commented Apr 9, 2020

fixed in: #2272

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants