Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[bug]: Question on buildpack dependencies #2913

Closed
2 of 7 tasks
fooman opened this issue Dec 20, 2020 · 2 comments
Closed
2 of 7 tasks

[bug]: Question on buildpack dependencies #2913

fooman opened this issue Dec 20, 2020 · 2 comments
Labels
bug Something isn't working Progress: done

Comments

@fooman
Copy link
Contributor

fooman commented Dec 20, 2020

Describe the bug
This might only impact me as I am building weekly packages of PWA-Studio here. This week's build failed due to the changes coming from #2891. More specifically the introduction of the lodash package in create.js

  ⓧ  Error: Buildpack could not find a valid
     '_buildpack/create.js' file in
     /home/runner/work/pwa-studio-starter/pwa-studio/packages/venia-concept.
     This file must be present to instruct Buildpack
     how to use the
     /home/runner/work/pwa-studio-starter/pwa-studio/packages/venia-concept
     package to perform the "create" operation.
     Original error: Cannot find module 'lodash'
     Require stack:
     -
     /home/runner/work/pwa-studio-starter/pwa-studio/packages/venia-concept/_buildpack/create.js

I believe I am only seeing this but not you is that I only used pwa-buildpack to package. While create.js does reside in venia-concept (which has a dependency on lodash). I believe the dependencies of the to-be-packaged package should not require installing.

To reproduce
Steps to reproduce the behavior:

  1. git clone
  2. cd packages/pwa-buildpack
  3. npm install
  4. DEBUG_PROJECT_CREATION=true ./packages/pwa-buildpack/bin/buildpack create-project ../tmp-to-delete --template "venia-concept" --name "pwa-studio-canary" --author "Test Authoruser@example.com" --backend-url "https://master-7rqtwti-mfwmkrjfqvbjk.us-4.magentosite.cloud/" --braintree-token "sandbox_8yrzsvtm_s2bg8fs563crhqzk" --npm-client "yarn" --install 0

Expected behavior
buildpack succeeds

Possible solutions
Add lodash to pwa-buildpack update this seems to be the case already

Please complete the following device information:

  • Device [e.g. iPhone6, PC, Mac, Pixel3]:
  • OS [e.g. iOS8.1, Windows 10]:
  • Browser [e.g. Chrome, Safari]:
  • Browser Version [e.g. 22]:
  • Magento Version:
  • PWA Studio Version:
  • NPM version npm -v:
  • Node Version node -v:

Please let us know what packages this bug is in regards to:

  • venia-concept
  • venia-ui
  • pwa-buildpack
  • peregrine
  • pwa-devdocs
  • upward-js
  • upward-spec
  • [] create-pwa
@fooman fooman added the bug Something isn't working label Dec 20, 2020
@m2-assistant
Copy link

m2-assistant bot commented Dec 20, 2020

Hi @fooman. Thank you for your report.
To help us process this issue please make sure that you provided sufficient information.

Please, add a comment to assign the issue: @magento I am working on this


@fooman
Copy link
Contributor Author

fooman commented Dec 20, 2020

Solved the chicken/egg problem I had with yarn install on the repo level and that solved it.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working Progress: done
Projects
None yet
Development

No branches or pull requests

1 participant