You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
This might only impact me as I am building weekly packages of PWA-Studio here. This week's build failed due to the changes coming from #2891. More specifically the introduction of the lodash package in create.js
ⓧ Error: Buildpack could not find a valid
'_buildpack/create.js' file in
/home/runner/work/pwa-studio-starter/pwa-studio/packages/venia-concept.
This file must be present to instruct Buildpack
how to use the
/home/runner/work/pwa-studio-starter/pwa-studio/packages/venia-concept
package to perform the "create" operation.
Original error: Cannot find module 'lodash'
Require stack:
-
/home/runner/work/pwa-studio-starter/pwa-studio/packages/venia-concept/_buildpack/create.js
I believe I am only seeing this but not you is that I only used pwa-buildpack to package. While create.js does reside in venia-concept (which has a dependency on lodash). I believe the dependencies of the to-be-packaged package should not require installing.
Describe the bug
This might only impact me as I am building weekly packages of PWA-Studio here. This week's build failed due to the changes coming from #2891. More specifically the introduction of the lodash package in create.js
I believe I am only seeing this but not you is that I only used pwa-buildpack to package. While create.js does reside in venia-concept (which has a dependency on lodash). I believe the dependencies of the to-be-packaged package should not require installing.
To reproduce
Steps to reproduce the behavior:
Expected behavior
buildpack succeeds
Possible solutions
Add lodash to pwa-buildpackupdate this seems to be the case alreadyPlease complete the following device information:
npm -v
:node -v
:Please let us know what packages this bug is in regards to:
venia-concept
venia-ui
pwa-buildpack
peregrine
pwa-devdocs
upward-js
upward-spec
create-pwa
The text was updated successfully, but these errors were encountered: