-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[feature]: Tailwind v3 support #4081
Comments
Hi @justinconabree. Thank you for your report. Join Magento Community Engineering Slack and ask your questions in #github channel. |
@magento I am working on this |
hey @justinconabree could you please let us know furthure updates on same as you are working on PR as per link |
Hi @glo42707 , Just jumped back onto this. Just working on changing media queries over to tailwind and then will pass over the site for QA/lint fixes/cypress screenshot updates. I'll try to have it finished by end of week and then the PR to non-draft when it's ready. Also just a note that it won't impact the pagebuilder extension as none of that code is converted to Tailwind at the moment so it's a bigger job. I'll tag you in the PR when it's changed from draft status Thanks! |
@adobe export issue to JIRA project PWA as Bug |
✅ Jira issue https://jira.corp.adobe.com/browse/PWA-3174 is successfully created for this GitHub issue. |
Is your feature request related to a problem? Please describe.
Not a problem necessarily. Tailwind v3 comes with some additional utilities which are helpful for development.
Describe the solution you'd like
Update to Tailwind v3. At the same time it would be good to address some of the issues with the current tailwind implementation in venia components (direct css use, priority issues,
@TODO
tailwind comments, hardcoded values in tokens.module.css/index.module.css files)Describe alternatives you've considered
N/A
Additional context
N/A
Please let us know what packages this feature is in regards to:
venia-concept
venia-ui
pwa-buildpack
peregrine
pwa-devdocs
upward-js
upward-spec
create-pwa
pwa-theme-venia
The text was updated successfully, but these errors were encountered: