Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[feature]: Tailwind v3 support #4081

Closed
3 of 9 tasks
justinconabree opened this issue Apr 11, 2023 · 6 comments · Fixed by #4196
Closed
3 of 9 tasks

[feature]: Tailwind v3 support #4081

justinconabree opened this issue Apr 11, 2023 · 6 comments · Fixed by #4196

Comments

@justinconabree
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Not a problem necessarily. Tailwind v3 comes with some additional utilities which are helpful for development.

Describe the solution you'd like
Update to Tailwind v3. At the same time it would be good to address some of the issues with the current tailwind implementation in venia components (direct css use, priority issues, @TODO tailwind comments, hardcoded values in tokens.module.css/index.module.css files)

Describe alternatives you've considered
N/A

Additional context
N/A

Please let us know what packages this feature is in regards to:

  • venia-concept
  • venia-ui
  • pwa-buildpack
  • peregrine
  • pwa-devdocs
  • upward-js
  • upward-spec
  • create-pwa
  • pwa-theme-venia
@justinconabree justinconabree added the enhancement New feature or request label Apr 11, 2023
@m2-assistant
Copy link

m2-assistant bot commented Apr 11, 2023

Hi @justinconabree. Thank you for your report.
To speed up processing of this issue, make sure that you provided sufficient information.
Add a comment to assign the issue: @magento I am working on this


Join Magento Community Engineering Slack and ask your questions in #github channel.

@justinconabree
Copy link
Contributor Author

@magento I am working on this

@glo42707 glo42707 added triage-done Priority: P1 Issue: Needs Update Additional information is require, waiting for response labels Jun 8, 2023
@glo42707
Copy link
Contributor

glo42707 commented Jun 8, 2023

hey @justinconabree

could you please let us know furthure updates on same as you are working on PR as per link
#4082

@justinconabree
Copy link
Contributor Author

Hi @glo42707 ,

Just jumped back onto this. Just working on changing media queries over to tailwind and then will pass over the site for QA/lint fixes/cypress screenshot updates. I'll try to have it finished by end of week and then the PR to non-draft when it's ready.

Also just a note that it won't impact the pagebuilder extension as none of that code is converted to Tailwind at the moment so it's a bigger job.

I'll tag you in the PR when it's changed from draft status

Thanks!

@glo42707
Copy link
Contributor

glo42707 commented Aug 7, 2023

@adobe export issue to JIRA project PWA as Bug

@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/PWA-3174 is successfully created for this GitHub issue.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants