Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Variable Re-use in Foreach #62

Closed
bbatsche opened this issue Mar 6, 2019 · 0 comments
Closed

Variable Re-use in Foreach #62

bbatsche opened this issue Mar 6, 2019 · 0 comments

Comments

@bbatsche
Copy link
Member

bbatsche commented Mar 6, 2019

That is some bad bad variable usage there. Found while researching magento/magento2-upward-connector#10. I don't think it's the source of the specific error, but it certain isn't helping the situation.

https://github.com/magento-research/upward-php/blob/6a705e6c8169a0d9d714992dffbb35c9559c95d8/src/Resolver/Template.php#L56
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@bbatsche