Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Unit tests - 2 failures #22

Closed
GoogleCodeExporter opened this issue Mar 21, 2015 · 4 comments
Closed

Unit tests - 2 failures #22

GoogleCodeExporter opened this issue Mar 21, 2015 · 4 comments

Comments

@GoogleCodeExporter
Copy link

What steps will reproduce the problem?
1.Run unit tests
2.
3.

What is the expected output?
No failures

What is the actual output?
2 failures

What version of ez-vcard are you using?
0.9.6

What version of Java are you using?
1.7

Please provide any additional information below.
1. ezvcard.io.html.create_then_parse()
2. ezvcard.io.xml.XCardWriterTest.write_prettyPrint()

Original issue reported on code.google.com by siegelm...@gmail.com on 5 Nov 2014 at 10:19

@GoogleCodeExporter
Copy link
Author

Sorry, #1 should have read 'ezvcard.io.html.HCardPageTest.create_then_parse()'. 
Newline issues in both cases, fixes are below.

Fix for #1 on line 426:
adr.setLabel("123 Main St." + NEWLINE + "Austin TX, 12345" + NEWLINE + "USA");

Fix for #2 on line 578:
String nl = ezvcard.util.StringUtils.NEWLINE;



Original comment by siegelm...@gmail.com on 5 Nov 2014 at 10:46

@GoogleCodeExporter
Copy link
Author

Fixed in r1067.  Thanks for the report!

Original comment by mike.angstadt on 5 Nov 2014 at 11:11

  • Changed state: Fixed

@GoogleCodeExporter
Copy link
Author

FYI - you cut the 5th digit ('5') off the zip code.

Original comment by siegelm...@gmail.com on 5 Nov 2014 at 11:45

@GoogleCodeExporter
Copy link
Author

Haha, whoops, thanks.

Original comment by mike.angstadt on 5 Nov 2014 at 11:53

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

1 participant