Remove dependence on FilteredTimeSeriesProperty from ISISRunLogs #34927
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #34794 this starts removing dependency on
FilteredTimeSeriesProperty
which is only used by one algorithm,ISSRunLogs
. The change is to filter the logs the same way as everywhere else currently in mantid by removing and adding values for the various windows.To test:
This is a refactor that should not break any existing tests.
There is no associated issue.
This does not require release notes because it is a refactor of underlying code.
Reviewer
Please comment on the following (full description):
Code Review
Functional Tests
Does everything look good? Mark the review as Approve. A member of
@mantidproject/gatekeepers
will take care of it.