-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Fix bug #74 #91
base: main
Are you sure you want to change the base?
Fix bug #74 #91
Conversation
With this PR , it could solve the problem in #74 : |
Cool! Can you describe the logic in more detail here? |
the key code is : var toRemove = false;
if (!p.steiner) {
if (equals(p, p.next) || equals(p.prev, p)) {
toRemove = true;
} else if (area(p.prev, p, p.next) === 0) {
// If `p.prev, p & p.next` are on holes (not outer edge) ,
// And `p.prev & p` are on the same hole ,
// Then do NOT remove `p` .
if (prevHole && nextHole && prevHole !== nextHole && prevHole === currentHole) {
toRemove = false;
} else {
toRemove = true;
}
}
} But there is something I can't understand about
if no |
Is there any news about this pr & issue ? |
Is there any news about this pr & issue ??? |
@finscn sorry, I didn't have the chance to thoroughly review it yet. It's on my list. Feel free to use your forked version in the mean time. |
I don't mean to add useless noise, but I'd be interested if there is a chance of this PR getting merged anytime soon. |
Updated LICENSE to be in-line with Mapbox's ISC requirements
Only
water-huge2
failed .the log says :
I think maybe something is wrong in the test-case.