Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Missing "file" custom property type support. #59

Closed
MaulingMonkey opened this issue Sep 3, 2019 · 1 comment · Fixed by #95
Closed

Missing "file" custom property type support. #59

MaulingMonkey opened this issue Sep 3, 2019 · 1 comment · Fixed by #95

Comments

@MaulingMonkey
Copy link

MaulingMonkey commented Sep 3, 2019

https://doc.mapeditor.org/en/stable/manual/custom-properties/#adding-properties lists "file" properties, which don't appear to be supported in PropertyValue::new:

https://github.com/mattyhall/rs-tiled/blob/06e4ecf4257e4dd0813087e1fcd642d7f0ce7713/src/lib.rs#L167-L198

@MaulingMonkey
Copy link
Author

It also might be worth adding a:

#[doc(hidden)] __NonExhaustive,

case to the enum. There's a whole slew of possible future extensions planned for the custom properties section:

...and without a __NonExhaustive case, adding new enumeration values for any of these would be a breaking change, as existing match statements become nonexhaustive.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant