-
-
Notifications
You must be signed in to change notification settings - Fork 689
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Can't disable all sky rendering when terrain is enabled #4517
Comments
It also seems like when trying to enable again the sky using the checkbox it doesn't bring them back. maplibre-gl-js/src/style/sky.ts Line 60 in e6b4436
Feel free to investigate. |
Should be fixed by #4587 and released shortly after this is merged. |
Just managed to check this out. Maybe I am misunderstanding something but this does not appear to fix the issue. I've attached two screenshots of the same strip of horizon, one with terrain enabled, one without terrain and otherwise identical. Both have sky disabled (via |
Can you check how this looks before sky was added (version 4.0 for example) |
Can you open a different issue then? Jsbin would be helpful to see the difference between versions and rendering. |
You want me to open the same issue again? I opened this issue to fix the bug I'm highlighting and it has a JSBin to enable switching the version to compare |
Sorry, my mistake, no need, I reread the original post... |
There were multiple issues in this report I guess... |
Should be fixed in #4607. |
maplibre-gl-js version: 4.5.1
browser: Vivaldi 6.8.3381.48
Steps to Trigger Behavior
map.setSky(undefined)
)Link to Demonstration
https://jsbin.com/hibilakuno/edit?html,output
Expected Behavior
The sky/horizon/fog rendering is disabled when terrain is enabled when calling
setSky(undefined)
orsky: undefined
in a style specActual Behavior
Only sky rendering is disabled when terrain is enabled
The text was updated successfully, but these errors were encountered: