Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

MarkerView TypeScript type doesn't extend ViewProps #41

Closed
danshilm opened this issue Apr 27, 2023 · 0 comments · Fixed by #42
Closed

MarkerView TypeScript type doesn't extend ViewProps #41

danshilm opened this issue Apr 27, 2023 · 0 comments · Fixed by #42

Comments

@danshilm
Copy link
Contributor

danshilm commented Apr 27, 2023

Steps to Trigger Behavior

  1. Add a MarkerView component.
  2. Add another component as a child of that MarkerView component.
  3. Get sad because TypeScript is screaming at me.

Link to Minimal Reproducible Example

Not minimal, but it's occurring here.
Can definitely make a minimal example if needed.

Expected Behavior

Actual Behavior

Screenshots (if applicable)

Version(s) affected

  • Platform: [e.g. Android, iOS]
  • OS version: [e.g. Android 9, iOS 10]
  • Device type: [e.g. iPhone6]
  • Emulator/ Simulator: [yes/ no]
  • Development OS: [e.g. OSX 11.0.1, Win10]
  • maplibre-react-native Version: 9.0.1
  • MapLibre GL version [e.g. 6.3.0]
  • React Native Version [e.g. 0.59]

Additional context

Looking at the code for the MarkerView, it seems like it's only the Typescript Type that needs to be updated since the actual component itself already extends the ViewProps prop-type.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant