Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Mark matching nodes even if parent was matched in branch mode #529

Closed
sanjay-git opened this issue Dec 3, 2015 · 0 comments
Closed

Mark matching nodes even if parent was matched in branch mode #529

sanjay-git opened this issue Dec 3, 2015 · 0 comments

Comments

@sanjay-git
Copy link

Currently, for the tree.filterBranches, if the parent node and child node both matches the filter, only the parent gets highlighted. There are two caveats for this:

  1. Matched Child node doesn't get highlighted
  2. Matched parent node doesn't get expanded

I found that this is happening because of the line return "skip"; inside _applyFilterImpl

Suggested code change:

tree.filterBranches(match, {autoExpand: true, filterMatchedParent: true})

Inside _applyFilterImpl

filterMatchedParent = !!opts.filterMatchedParent;

if(!filterMatchedParent) {
return "skip";
}

@mar10 mar10 changed the title Feature Request: Filter/Highlight the child nodes even after branch is filtered for tree.filterBranches() Mark matching nodes even if parent was matched in branch mode Nov 13, 2016
@mar10 mar10 closed this as completed in c3c7e9e Nov 13, 2016
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

2 participants