Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

'$.ui.fancytree.getNode(jQuery)' fails on jQuery v3.x #702

Closed
mdarim opened this issue Mar 13, 2017 · 3 comments
Closed

'$.ui.fancytree.getNode(jQuery)' fails on jQuery v3.x #702

mdarim opened this issue Mar 13, 2017 · 3 comments

Comments

@mdarim
Copy link

mdarim commented Mar 13, 2017

Thanks for contributing :-)

Expected and actual behavior

I updated the contextMenu demo page to use jQuery v3.1.0 instead of version 1.12.1, then when I run the demo the context menu showed fine but after selection it display node with "null" value. my expected behavior is the context extension demo supported with jQuery v3.1.0.
1

capture

Steps to reproduce the problem

  1. Open the file fancytree-master/3rd-party/extensions/contextmenu/contextmenu.html
  2. repalce the <script src="//code.jquery.com/jquery-1.12.1.min.js"></script> line with <script src="//code.jquery.com/jquery-3.1.0.min.js"></script>
  3. run and select a node and see what will be displayed.

This is a Plunker working demo using jQuery 1.12.1
http://embed.plnkr.co/TuIOcpJ3R9tNUizvte5p/

This is a Plunker not working demo using jQuery 3.1.0
http://embed.plnkr.co/sp0zJBJQWcdmqR6O22G9/

Environment

  • Browser type and version: chrome, ie11, edge
  • jQuery and jQuery UI versions: jQuery 3.1.0 , jQuery UI 1.11.4
  • Fancytree version: latest version.
    enabled/affected extensions: contextMenu.

Does this extension or jquery context plugin supports jquery 3 or not yet ?

@mar10
Copy link
Owner

mar10 commented Mar 14, 2017

Thanks for reporting this.
It seems you found a more general problem, regarding the getNode() helper.
I changed the title accordingly.

@mar10 mar10 changed the title 'contextMenu' extension using jQuery v3.1.0 not working '$.ui.fancytree.getNode(jQuery)' fails on jQuery v3.x Mar 14, 2017
@mar10 mar10 closed this as completed in e93c5bd Mar 14, 2017
@TheMightyPope
Copy link

TheMightyPope commented Oct 13, 2017

Is there a fix for this? Just happened to me using latest JQuery 3.2.1, and context menu 2.25.0

@mar10
Copy link
Owner

mar10 commented Oct 14, 2017

@TheMightyPope yes it should have been fixed in march.
Seems to run here http://wwwendt.de/tech/fancytree/demo/index.html#sample-3rd-jQuery-contextMenu.html, at least in safari.
Can you give more information?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants