Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Extract modules into a standalone repo like babysitter #1494

Closed
samccone opened this issue Jun 18, 2014 · 4 comments
Closed

Extract modules into a standalone repo like babysitter #1494

samccone opened this issue Jun 18, 2014 · 4 comments
Milestone

Comments

@samccone
Copy link
Member

This is the first step towards #1321

This can be done in a non breaking change. This also goes also with our push to convert all the pieces of marionette into requirable pieces

#1332

@samccone samccone added this to the v2.1 milestone Jun 18, 2014
@jamiebuilds
Copy link
Member

I'm not sure that is the right approach since it's doesn't work towards the end goal of removing modules.

If we create a separate library, people will switch to it and then continue using modules just as much, and then we'll have to support the separate library despite moving away from modules.

Sure we can then deprecate the separate library, but why not do that in the first place with the message that it will be replaced in v3?

I'd rather see us build a separate lib with the new architectural components, saying that they are a replacement for several things in Marionette, with the promise that the library will be merged with Marionette in v3. Then people will work towards using that, and we can immediately deprecate modules.

👎

@jamesplease
Copy link
Member

👎

  1. this is not a priority until the major architecture release nears. It isn't anytime soon.
  2. there is no goal of splitting Marionette into separate repositories. In fact, I think we have the goal of bringing the pieces back together
  3. the only affect this would have on users is requiring them to do more work. They would need to update their build system immediately, then, at a later date, switch to Namespaces. yuck.
  4. modules are, and will continue to be, a part of Marionette core. Separating them out confuses this fact.

The real solution is that we don't do anything right now, and focus our attention on other things. Then, sometime later we can make the Marionette.Namespaces library as a separate repo. We can do this before the architectural release so people can swap over before the other big changes.

@jamesplease
Copy link
Member

Also, the goal of splitting the Classes up into separate modules is a little nice-to-have that won't matter to the majority of people, and it shouldn't affect the core library in any way, I think. I don't think we should use that side-project as an argument in favor of sweeping changes to the repository structure. It should really be it's own, separate little thing.

@jasonLaster
Copy link
Member

👍 @jmeas @thejameskyle. I'm in favor of closing this issue for those reasons

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants