-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Rename 'rootEl' param on application to 'region' #2770
Comments
Why not rootRegion? |
Backbone view receives model, option is called model and is available in view as this.model. Marionette region has option el with the same conventions. This application.region looks quite similar. |
I did but I wasn't sure it was the right place. Shall I close this one and we continue in PR? |
Closing for continuation on PR |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
RootEl indicates, well, element. Why not call it just 'region'? Name 'rootEl' doesnt work very well when you want to pass previously created region. With 'region' name, it can still be initialized as el, selector or region, but will give us a much nicer pattern for child apps - basically every app could have a region to use passed from outside (eg parent app or main):
Also, regions' show (and maybe also getRegion) can be aliased directly on app (from this.region and this.region.currentView resp.)
The text was updated successfully, but these errors were encountered: