We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
the getOption method have falsy check for keyName and this may lead for some unexpected results. link to source:
backbone.marionette/src/common/get-option.js
Line 7 in 0b38315
example:
const falsyKey = 0; const view = new Mn.View({ [falsyKey]: 'some value' }); console.log(view.getOption(falsyKey)) // undefined; console.log(view.options[falsyKey]) // somev value;
the codepen: https://codepen.io/dimatabu/pen/vYWwyMR?editors=0010
solution:
const getOption = function(optionName) { - if (!optionName) { return; } + if (!arguments.length) { return; } };
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Description
the getOption method have falsy check for keyName and this may lead for some unexpected results.
link to source:
backbone.marionette/src/common/get-option.js
Line 7 in 0b38315
example:
the codepen: https://codepen.io/dimatabu/pen/vYWwyMR?editors=0010
solution:
The text was updated successfully, but these errors were encountered: