From c4f9403ecffdefff892085bedd32c4d8da4c02d3 Mon Sep 17 00:00:00 2001 From: Marius Begby Date: Wed, 13 Sep 2023 20:42:56 +0200 Subject: [PATCH] fix: fix duration validation not using padded and formatted duration --- src/interactions/commands/player/seek.ts | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/interactions/commands/player/seek.ts b/src/interactions/commands/player/seek.ts index 466b05e9..94af636b 100644 --- a/src/interactions/commands/player/seek.ts +++ b/src/interactions/commands/player/seek.ts @@ -33,7 +33,7 @@ class SeekCommand extends BaseSlashCommandInteraction { const durationInputSplit: string[] = interaction.options.getString('duration')!.split(':'); const formattedDurationString: string = this.parseDurationArray(durationInputSplit); - if (!this.validateDurationFormat(durationInputSplit, formattedDurationString)) { + if (!this.validateDurationFormat(formattedDurationString)) { return await this.handleInvalidDurationFormat(logger, interaction, formattedDurationString); } @@ -149,12 +149,13 @@ class SeekCommand extends BaseSlashCommandInteraction { return durationInputSplit.join(':'); } - private validateDurationFormat(durationInputSplit: string[], formattedDurationString: string): boolean { - if (durationInputSplit.length === 0 || durationInputSplit.length > 3) { + private validateDurationFormat(formattedDurationString: string): boolean { + const formattedDurationSplit: string[] = formattedDurationString.split(':'); + if (formattedDurationSplit.length === 0 || formattedDurationSplit.length > 3) { return false; } - if (!durationInputSplit.every((value) => value.length === 2)) { + if (!formattedDurationSplit.every((value) => value.length === 2)) { return false; }