Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

There's no security #3

Closed
SimonEast opened this issue Aug 3, 2017 · 3 comments · Fixed by #4
Closed

There's no security #3

SimonEast opened this issue Aug 3, 2017 · 3 comments · Fixed by #4

Comments

@SimonEast
Copy link

Some websites have sections or entries which are not designed to be public. There needs to be a way to whitelist (preferably) or blacklist which sections or entry types can be accessed via this API.

I haven't tested, but I think the Users section should definitely be heavily guarded too so it cannot be queried unless specifically required.

@markhuot
Copy link
Owner

markhuot commented Aug 4, 2017

Good report, thanks.

Re: hidden sections, this is definitely on the roadmap. Right now you have to auth with a user token to access the GraphQL service. The thought is that you would be able to query any sections you have access to.

Re: users, I haven't given this much thought yet. I'm open to ideas on how to lock this down. Right now you can make tokens that are read or read/write. I could extend that with some concept of "scopes" that conditionally allows user access too…

@markhuot
Copy link
Owner

markhuot commented Aug 4, 2017

Something like this,

screen shot 2017-08-03 at 11 14 41 pm

(working on it over in the scopes branch)

@markhuot
Copy link
Owner

This was fixed up with #4. Scopes are now implemented on a per-token basis. You can exclude specific types by either query or mutation.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants