Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support dark themes like Dark Metal #8

Closed
markiewb opened this issue Feb 2, 2015 · 10 comments
Closed

Support dark themes like Dark Metal #8

markiewb opened this issue Feb 2, 2015 · 10 comments
Labels
Milestone

Comments

@markiewb
Copy link
Collaborator

markiewb commented Feb 2, 2015

ACTUAL: black text on white background.
EXPECTED: white text on dark background.

@markiewb markiewb added the bug label Feb 2, 2015
@Chris2011
Copy link
Owner

A thing, what I would prefer is to set the outline view as an little overlay directly into the editor before the scrollbar, without having a separation. This is was Sublime Text 2 has: http://www.bit-101.com/blog/wp-content/uploads/2012/05/Screenshot-Documents-Playing-With-Chaos-Book-book-pwc_ch01.html-playing_with_chaos-Sublime-Text-2.png So maybe you can inherit the background or do a opacity for this, And it's a bit inconspicuous than now.

Regards

Chris

@markiewb
Copy link
Collaborator Author

markiewb commented Feb 5, 2015

I am sorry. AFAIK it is not possible to embed the view into the editor.
Neither the code outline plugins for Eclipse/IDEA do this.

Eclipse:
http://marketplace.eclipse.org/sites/default/files/styles/ds_solution_screenshot/public/overview_6.png?itok=Bv5c8K6G
Idea: http://plugins.jetbrains.com/files/6274/screenshot_14688.png

My plan is to use the use the background color of the editor. But the
outline cannot be placed at the left of the editor scrollbar

With kind regards, markiewb

2015-02-05 8:58 GMT+01:00 Chris2011 notifications@github.com:

A thing, what I would prefer is to set the outline view as an little
overlay directly into the editor before the scrollbar, without having a
separation. This is was Sublime Text 2 has:
http://www.bit-101.com/blog/wp-content/uploads/2012/05/Screenshot-Documents-Playing-With-Chaos-Book-book-pwc_ch01.html-playing_with_chaos-Sublime-Text-2.png
So maybe you can inherit the background or do a opacity for this, And it's
a bit inconspicuous than now.

Regards

Chris


Reply to this email directly or view it on GitHub
#8 (comment)
.

@Chris2011
Copy link
Owner

Is it not possible to do that like in HTML? I don't know java with swing good enough but I thought the editor has position relative (as a div in html) and the outline has position absolute and has top: 0 and right: 0 (like a div inside the relative div in html). Isn't it possible? Because of the swing components?

@thiagolucio
Copy link

I have a similar question to Chris2011. Which file i change de color apparence config this plugin? Which is the path to this file?

@markiewb
Copy link
Collaborator Author

markiewb commented Feb 5, 2015

@thiago: Sorry. There is no setting yet. Currently it is hardcoded. The
next version will use the colors from the Colors&Fonts options

Best regards, markiewb
On 5 Feb 2015 17:33, "Thiago Lúcio Bittencourt" notifications@github.com
wrote:

I have a similar question to Chris2011. Which file i change de color
apparence config this plugin? Which is the path to this file?


Reply to this email directly or view it on GitHub
#8 (comment)
.

@thiagolucio
Copy link

Thanks :)

markiewb added a commit that referenced this issue Feb 5, 2015
To fix:
light mode: make clip darker
dark mode: make clip lighter
@istvan-ujjmeszaros
Copy link

Would be great if we could configure the colors.

@p2rkw
Copy link

p2rkw commented Jun 23, 2015

I'm using dark theme, but in code outline both text and background are white (light grey).
If values are hardcoded why background colour is white? What is source of colours?
I don't have theme named "default", should I create one?

added:
If you hardcode you should hardcode both values, not only background color.

netbeans dev 04-06-2015
code outline 1.2.0

@luislobo
Copy link

Hi, great job with this plugin. Can you please merge your fix for dark background? thank you!

@markiewb markiewb modified the milestone: 1.3.0 Jan 4, 2016
markiewb added a commit that referenced this issue Jan 4, 2016
To fix:
light mode: make clip darker
dark mode: make clip lighter
markiewb added a commit that referenced this issue Jan 4, 2016
* Use colors from current editor - see ColorAndFontProvider
markiewb added a commit that referenced this issue Jan 4, 2016
@markiewb
Copy link
Collaborator Author

markiewb commented Jan 4, 2016

2016-01-04_23h46_58

2016-01-04_23h44_17

fixed in 1.3.0

@markiewb markiewb closed this as completed Jan 4, 2016
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants