Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Ensure singleton for update server #18

Open
markjaquith opened this issue May 7, 2013 · 2 comments
Open

Ensure singleton for update server #18

markjaquith opened this issue May 7, 2013 · 2 comments

Comments

@markjaquith
Copy link
Owner

The update server should be enforced as a singleton.
@markjaquith markjaquith mentioned this issue May 7, 2013
Merged
@Rarst
Copy link
Contributor

Rarst commented May 7, 2013

So let's say we add static TLC_Transient_Update_Server::start() method for spinning copy of singleton. Do we make constructor private, as it is usual for singletons? If someone out there is doing new separately that will be breaking change for them.

@Rarst
Copy link
Contributor

Rarst commented May 8, 2013

Alternate idea - what if we simply switch init() method to static? It will implicitly de-duplicate it on hooking. Server class doesn't seem to be doing anything that needs object instance so far.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@markjaquith @Rarst