Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Feature: Update astro-icon to v1 and svgo #89

Merged

Conversation

Ticolyle
Copy link
Contributor

@Ticolyle Ticolyle commented Jan 10, 2024

Hello! My compliments to an excellent astro starter repo with great baseline accessibility.

When I first tried out this repo I ran into issues with svgo and it's dependency sharp.

While troubleshooting the build, I found that astro-icon had been updated to v1 with some breaking changes. After updating in my personal project I found the changes to be fairly straightforward and thought to replicate for you on the main repo.

Most of the changes needed are documented in the astro-icon upgrade docs: https://www.astroicon.dev/guides/upgrade/v1/

I also needed to make some minor changes to the css styles to match the current site design. These changes are needed as the astro-icon now delivers icons with the width and height props, not previously present on the svg elements.

package.json changes:

- upgrade astro-icon 0.7.3 => 1.0.2
- upgrade svgo 2.8.0 => 3.2.0
- add @iconify-json/ion
- add @iconify-json/mdi

Cheers, and let me know if you have any questions.

Copy link

netlify bot commented Jan 10, 2024

Deploy Preview for accessible-astro ready!

Name Link
🔨 Latest commit dec9ca6
🔍 Latest deploy log https://app.netlify.com/sites/accessible-astro/deploys/659df65b11bcff00087806c7
😎 Deploy Preview https://deploy-preview-89--accessible-astro.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@markteekman
Copy link
Member

Hey @Ticolyle! Thanks for taking the time to upgrade Astro Icon on this repository, I always appreciate the help 😊 Your explanation is clear and the changes you've made look solid! Theres only one small issue, the Accessible Astro Components package still references to [astro-icon]. I'll fix that first and then merge your PR 😄 Thanks again!

@markteekman markteekman merged commit fc7b531 into incluud:main Jan 12, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants