Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

make.bat should detect when Perl is not installed #39

Open
marstr opened this issue Aug 8, 2019 · 0 comments
Open

make.bat should detect when Perl is not installed #39

marstr opened this issue Aug 8, 2019 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed windows-only Issues that are applicable when running baronial on Windows

Comments

@marstr
Copy link
Owner

marstr commented Aug 8, 2019

System Information
Version:  v0.1.1-modified
System: windows/amd64
Go:  go1.12.7
Source Revision:  af91355be2f7c0d8e5ec5ea2843d2964b7ab0ff9

What did you do?

Clone this repository onto a Windows machine that does not have a perl install, and execute .\make.bat install

What did you expect to happen?

make.bat should fail and report that perl must be installed to continue.

What actually happened?

perl is invoked, but the installation continues anyway. This can lead to system information being reported that doesn't capture version/revision information, or even worse garbage being used for those values.

Stack Trace
[Copy&Paste the error message that you got here.]
@marstr marstr added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers windows-only Issues that are applicable when running baronial on Windows labels Aug 8, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed windows-only Issues that are applicable when running baronial on Windows
Projects
None yet
Development

No branches or pull requests

1 participant