Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Angular2 RC6 integration? #2

Open
newmediamonkey opened this issue Sep 10, 2016 · 11 comments
Open

Angular2 RC6 integration? #2

newmediamonkey opened this issue Sep 10, 2016 · 11 comments

Comments

@newmediamonkey
Copy link

When I attempt to load ng2-summernote into RC6 version of Angular 2, I get the following errors:

node_modules/ng2-summernote/ng2-summernote.ts(20,50): error TS2304: Cannot find name 'Provider'.
[0] node_modules/ng2-summernote/ng2-summernote.ts(129,18): error TS2339: Property 'toPromise' does not exist on type 'Observable'.
[0] node_modules/ng2-summernote/node_modules/@angular/forms/src/directives.d.ts(44,39): error TS2314: Generic type 'Type' requires 1 type argument(s).
[0] node_modules/ng2-summernote/node_modules/@angular/forms/src/directives.d.ts(48,48): error TS2314: Generic type 'Type' requires 1 type argument(s).
[0] node_modules/ng2-summernote/node_modules/@angular/forms/src/form_providers.d.ts(13,38): error TS2314: Generic type 'Type' requires 1 type argument(s).

I have loaded ng2-summernote through ngModule declarations:

import {Ng2Summernote} from 'ng2-summernote/ng2-summernote';

@NgModule({
imports: [...],
declarations: [... Ng2Summernote],
bootstrap: [AppComponent ...]
})
export class AppModule {
}

package.json:

"dependencies": {
"@angular/common": "2.0.0-rc.6",
"@angular/compiler": "2.0.0-rc.6",
"@angular/core": "2.0.0-rc.6",
"@angular/forms": "2.0.0-rc.6",
"@angular/http": "2.0.0-rc.6",
"@angular/platform-browser": "2.0.0-rc.6",
"@angular/platform-browser-dynamic": "2.0.0-rc.6",
"@angular/router": "3.0.0-rc.2",
"@angular/upgrade": "2.0.0-rc.6",
"angular2-in-memory-web-api": "0.0.18",
"bootstrap": "^3.3.6",
"core-js": "^2.4.1",
"ng2-summernote": "^1.10.7",
"reflect-metadata": "^0.1.3",
"rxjs": "5.0.0-beta.11",
"systemjs": "0.19.27",
"zone.js": "^0.6.17"
},

@martinsvb
Copy link
Owner

Hi, thank you for comment. I plan upgrade to RC.6. So, I will check it and let you know.

@thehashrocket
Copy link

This is happening in Angular2 Final as well. :/

@xeor
Copy link

xeor commented Oct 12, 2016

Have anyone gotten any work done on this? Angular 2 final have been out for "a while" 😋
I looked at the issues here, and it looks like they can almost all be closed at once if we get it to work with ng2.

If noone have started to work on this, I might give it a try..

@thehashrocket
Copy link

@xeor nope, not yet. haven't had time, honestly.

@xeor
Copy link

xeor commented Oct 15, 2016

I started working on getting this. I'm not able to work on this for a couple of days. If you want to take over, feel free. The changes are at xeor@c268340

What is missing is getting the angular 2 module part working correctly, and figuring out a good way of dealing with bootstrap and summernote as a jquery plugin..

@martinsvb
Copy link
Owner

Hi all,
sorry for late update, I was busy.
ng2-summernote actually works as component.
BR
Martin

@xeor
Copy link

xeor commented Oct 24, 2016

@martinsvb on angular 2 final? Can you give a quick example how you did it?

@martinsvb
Copy link
Owner

@xeor I added integration steps to readme file
Please, let me know, if it works
Thx, Martin

@xeor
Copy link

xeor commented Oct 25, 2016

I am getting zone.js:158 Uncaught Error: Unexpected value 'Ng2Summernote' declared by the module 'AppModule' now if I try to import it as a component.
It looks like angular/angular-cli#1514 (comment) might explain it. I tried copying all the files into my local environment and load it using import { Ng2Summernote } from './ng2-summernote/ng2-summernote'; instead. And it kinda worked, a little better. But now it ended up being stuck at the same error as in #3

@jarrettj
Copy link

@xeor same issues here.

@PTC-JoshuaMatthews
Copy link

PTC-JoshuaMatthews commented Nov 24, 2016

@xeor @jarrettj Same issue for me as well, did you guys find a solutions?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants