-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
major version number should be bumped; renaming flex.scss was a breaking change #31
Comments
Assuming that only Webpack users will be doing
|
Yes, this was indeed a breaking change in a patch update. Broke our project too :( |
Dang it. I knew something like this would have happened. :( My bad. Will look into it. |
I think a fix would be something like this:
|
+1 this broke our build! |
We solved this removing the usage of flex mixins and instead using plain CSS + adding postcss / autoprefixer in our build flow. |
@verlok it's not like this issue was difficult to fix, one just had to find and replace references to the file...switching to completely different tools isn't really a "solution", it's a non sequitur. |
We didn't do that only for solving this, but to use the real CSS instructions in general (not only for flex), which are also supported by code-hint in editors. Also, we can decide to stop supporting IE10 tomorrow and update the code only by changing a configuration. |
Wow, not having to support IE10 sounds nice! |
Per @fieg's suggestion I reverted the rename, bumped version, and republished release. Hopefully that fixes everyone's issues (or avoids future issues). Sorry for that, first repo with actual users and bower/npm stuff so you'll forgive me as I learn the ins and outs of maintenance. 😊 |
it looks like
flex.scss
was renamed to_flexbox.scss
. This has broken our projects that are using webpack with sass-loader and doingThe project-breaking happened spontaneously on our build server since version 1.0.2 is considered compatible with
^1.0.0
.Thanks for these awesome mixins!
The text was updated successfully, but these errors were encountered: