Skip to content
This repository was archived by the owner on Jan 13, 2025. It is now read-only.

Commit b0cecf1

Browse files
authored
fix(button): Fixed parameter default value in height mixin (#5244)
1 parent 491fddc commit b0cecf1

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

packages/mdc-button/README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ Mixin | Description
201201
`mdc-button-ink-color($color)` | Sets the ink color to the given color for an enabled button, and sets the icon color to the given color unless `mdc-button-icon-color` is also used.
202202
`mdc-button-disabled-ink-color($color)` | Sets the ink color to the given color for a disabled button, and sets the icon color to the given color unless `mdc-button-icon-color` is also used.
203203
`mdc-button-density($density-scale)` | Sets density scale for button. Supported density scale values (`-3`, `-2`, `-1`, `0`).
204-
`mdc-button-height($height)` | Sets custom height of button.
204+
`mdc-button-height($height)` | Sets custom height for button.
205205
`mdc-button-shape-radius($radius, $density-scale, $rtl-reflexive)` | Sets rounded shape to button with given radius size. `$density-scale` is only required when `$radius` value is in percentage unit, defaults to `$mdc-button-density-default-scale`. Set `$rtl-reflexive` to true to flip radius values in RTL context, defaults to false.
206206
`mdc-button-horizontal-padding($padding)` | Sets horizontal padding to the given number.
207207
`mdc-button-outline-color($color)` | Sets the outline color to the given color for an enabled button.

packages/mdc-button/_mixins.scss

+5-1
Original file line numberDiff line numberDiff line change
@@ -316,7 +316,11 @@ $mdc-button-ripple-target: ".mdc-button__ripple";
316316
}
317317
}
318318

319-
@mixin mdc-button-height($height, $query: $query) {
319+
///
320+
/// Sets custom height for button.
321+
/// @param {Number} $height - Height of button in `px`.
322+
///
323+
@mixin mdc-button-height($height, $query: mdc-feature-all()) {
320324
$feat-structure: mdc-feature-create-target($query, structure);
321325

322326
@include mdc-feature-targets($feat-structure) {

0 commit comments

Comments
 (0)