Skip to content
This repository was archived by the owner on Jan 13, 2025. It is now read-only.

Commit f3adce8

Browse files
jony666666asyncLiz
authored andcommitted
fix(data-table): change svg attribute name viewbox to viewBox (#5483) (#5493)
1 parent 83caa49 commit f3adce8

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

packages/mdc-data-table/README.md

+5-5
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ MDC Data Table component auto instantiates `MDCCheckbox` for header row checkbox
103103
<div class="mdc-checkbox mdc-data-table__header-row-checkbox mdc-checkbox--selected">
104104
<input type="checkbox" class="mdc-checkbox__native-control" aria-label="Checkbox for header row selection"/>
105105
<div class="mdc-checkbox__background">
106-
<svg class="mdc-checkbox__checkmark" viewbox="0 0 24 24">
106+
<svg class="mdc-checkbox__checkmark" viewBox="0 0 24 24">
107107
<path class="mdc-checkbox__checkmark-path" fill="none" d="M1.73,12.91 8.1,19.28 22.79,4.59" />
108108
</svg>
109109
<div class="mdc-checkbox__mixedmark"></div>
@@ -124,7 +124,7 @@ MDC Data Table component auto instantiates `MDCCheckbox` for header row checkbox
124124
<div class="mdc-checkbox mdc-data-table__row-checkbox">
125125
<input type="checkbox" class="mdc-checkbox__native-control" aria-labelledby="u0"/>
126126
<div class="mdc-checkbox__background">
127-
<svg class="mdc-checkbox__checkmark" viewbox="0 0 24 24">
127+
<svg class="mdc-checkbox__checkmark" viewBox="0 0 24 24">
128128
<path class="mdc-checkbox__checkmark-path" fill="none" d="M1.73,12.91 8.1,19.28 22.79,4.59" />
129129
</svg>
130130
<div class="mdc-checkbox__mixedmark"></div>
@@ -143,7 +143,7 @@ MDC Data Table component auto instantiates `MDCCheckbox` for header row checkbox
143143
<div class="mdc-checkbox mdc-data-table__row-checkbox mdc-checkbox--selected">
144144
<input type="checkbox" class="mdc-checkbox__native-control" checked aria-labelledby="u1"/>
145145
<div class="mdc-checkbox__background">
146-
<svg class="mdc-checkbox__checkmark" viewbox="0 0 24 24">
146+
<svg class="mdc-checkbox__checkmark" viewBox="0 0 24 24">
147147
<path class="mdc-checkbox__checkmark-path" fill="none" d="M1.73,12.91 8.1,19.28 22.79,4.59" />
148148
</svg>
149149
<div class="mdc-checkbox__mixedmark"></div>
@@ -162,7 +162,7 @@ MDC Data Table component auto instantiates `MDCCheckbox` for header row checkbox
162162
<div class="mdc-checkbox mdc-data-table__row-checkbox mdc-checkbox--selected">
163163
<input type="checkbox" class="mdc-checkbox__native-control" checked aria-labelledby="u2"/>
164164
<div class="mdc-checkbox__background">
165-
<svg class="mdc-checkbox__checkmark" viewbox="0 0 24 24">
165+
<svg class="mdc-checkbox__checkmark" viewBox="0 0 24 24">
166166
<path class="mdc-checkbox__checkmark-path" fill="none" d="M1.73,12.91 8.1,19.28 22.79,4.59" />
167167
</svg>
168168
<div class="mdc-checkbox__mixedmark"></div>
@@ -181,7 +181,7 @@ MDC Data Table component auto instantiates `MDCCheckbox` for header row checkbox
181181
<div class="mdc-checkbox mdc-data-table__row-checkbox">
182182
<input type="checkbox" class="mdc-checkbox__native-control" aria-labelledby="u3"/>
183183
<div class="mdc-checkbox__background">
184-
<svg class="mdc-checkbox__checkmark" viewbox="0 0 24 24">
184+
<svg class="mdc-checkbox__checkmark" viewBox="0 0 24 24">
185185
<path class="mdc-checkbox__checkmark-path" fill="none" d="M1.73,12.91 8.1,19.28 22.79,4.59" />
186186
</svg>
187187
<div class="mdc-checkbox__mixedmark"></div>

packages/mdc-data-table/test/component.test.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ const mdcCheckboxTemplate = (props: Partial<CheckboxTemplateProps>): string => {
4848
<input type="checkbox" class="mdc-checkbox__native-control" ${
4949
props.isChecked ? 'checked' : ''}></input>
5050
<div class="mdc-checkbox__background">
51-
<svg class="mdc-checkbox__checkmark" viewbox="0 0 24 24">
51+
<svg class="mdc-checkbox__checkmark" viewBox="0 0 24 24">
5252
<path class="mdc-checkbox__checkmark-path" fill="none" d="M1.73,12.91 8.1,19.28 22.79,4.59"></path>
5353
</svg>
5454
<div class="mdc-checkbox__mixedmark"></div>

0 commit comments

Comments
 (0)