This repository was archived by the owner on Jan 13, 2025. It is now read-only.
fix(core): Fix canary release by excluding test files from default tsconfig #5317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5317 +/- ##
======================================
Coverage 98.3% 98.3%
======================================
Files 162 162
Lines 6311 6311
Branches 866 866
======================================
Hits 6204 6204
Misses 106 106
Partials 1 1Continue to review full report at Codecov.
|
patrickrodee
approved these changes
Dec 9, 2019
joyzhong
changed the title
joyzhong
changed the title
|
All 731 screenshot tests passed for commit 282a257 vs. |
joyzhong
changed the title
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, test files in the tsconfig are causing
package/<component>/index.jsnot to be generated when runningnpm run build:esmodules, leading to a failure in the canary release: https://github.com/material-components/material-components-web/runs/340549500