Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Icons #7223

Closed
Simbiat opened this issue Aug 24, 2022 · 5 comments
Closed

Icons #7223

Simbiat opened this issue Aug 24, 2022 · 5 comments

Comments

@Simbiat
Copy link
Contributor

Simbiat commented Aug 24, 2022

Not an issue, but suggestion: I've bothered enough to create a collection of icons here based on names of OSs and apps from regex yaml files in the library. I plan to use it for an audit page so that it won't be just text.
Since it may be useful for others doing something similar, perhaps there is a point in adding link to the collection to README of the Device Detector? Or is it too niche?

@Findus23
Copy link
Member

Just FYI, while it doesn't cover the same set of names, Matomo Icons (https://github.com/matomo-org/matomo-icons/) might be of interest for you.

@Simbiat
Copy link
Contributor Author

Simbiat commented Aug 25, 2022

It is a nice collection as well, but it may not be as convenient to use with Device Detector. I've added a sample code to readme of my repository.

@Findus23
Copy link
Member

Indeed, but just to document it: You can use matomo-icons using the same code that Matomo uses which I simplified here:
https://github.com/Findus23/devicedetector.net/blob/master/src/IconPath.php

for use at https://devicedetector.lw1.at

@Simbiat
Copy link
Contributor Author

Simbiat commented Aug 25, 2022

Maybe then both should be mentioned in README for Device Detector?

@Simbiat
Copy link
Contributor Author

Simbiat commented Aug 15, 2023

Updated my library of icons and remembered about this thread today 😅 So, should we add links to the 2 packs to README? I can create a PR, but I certainly do not want to make it look like I am shamelessly advertising my own library

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

3 participants