From 1a7a9ddd0a001abc82f51dc8bf20ef00ccdecf10 Mon Sep 17 00:00:00 2001 From: Liviu-Mihail Concioiu Date: Sun, 25 Aug 2024 23:34:17 +0200 Subject: [PATCH] Improves version detection for Brave --- Tests/Parser/Client/fixtures/browser.yml | 9 +++++++++ regexes/client/browsers.yml | 2 +- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/Tests/Parser/Client/fixtures/browser.yml b/Tests/Parser/Client/fixtures/browser.yml index 455a8b9473..eaf7aa569c 100644 --- a/Tests/Parser/Client/fixtures/browser.yml +++ b/Tests/Parser/Client/fixtures/browser.yml @@ -9808,3 +9808,12 @@ family: Chrome headers: Sec-CH-UA: '"Chromium";v="122", "Not(A:Brand";v="24", "XiaoMiBrowser";v="122"' +- + user_agent: Mozilla/5.0 (Linux; Android 7.0; SM-G920F) AppleWebKit/537.36 (KHTML, like Gecko) Brave Chrome/85.0.4183.121 Mobile Safari/537.36 + client: + type: browser + name: Brave + version: 85.0.4183.121 + engine: Blink + engine_version: 85.0.4183.121 + family: Chrome diff --git a/regexes/client/browsers.yml b/regexes/client/browsers.yml index 86064252ec..6f4998e2c8 100644 --- a/regexes/client/browsers.yml +++ b/regexes/client/browsers.yml @@ -1805,7 +1805,7 @@ version: '$1' engine: default: 'Blink' -- regex: 'Brave(?:/(\d+[\.\d]+))?' +- regex: 'Brave(?: Chrome)?(?:/(\d+[\.\d]+))?' name: 'Brave' version: '$1' engine: