Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

consider swapping sortedcontainers.SortedDict for blist.sorteddict #3098

Closed
richvdh opened this issue Apr 13, 2018 · 2 comments
Closed

consider swapping sortedcontainers.SortedDict for blist.sorteddict #3098

richvdh opened this issue Apr 13, 2018 · 2 comments
Labels
z-minor (Deprecated Label) z-p2 (Deprecated Label)

Comments

@richvdh
Copy link
Member

richvdh commented Apr 13, 2018

This would increase compatibility with pypy, and allegedly would be more performant.

We tried this before, but had to revert it (d3347ad) . I'd like to see some unit tests for the code in question before we try it again.
@richvdh richvdh mentioned this issue Apr 13, 2018
Merged
@neilisfragile neilisfragile added z-p2 (Deprecated Label) z-minor (Deprecated Label) labels Apr 20, 2018
@Valodim
Copy link
Contributor

Valodim commented Nov 11, 2018

seems like synapse is using sortedcontainers instead of blist at this point?

@richvdh
Copy link
Member Author

richvdh commented Nov 12, 2018

indeed, this was apparently fixed in #3332. thanks.

@richvdh richvdh closed this as completed Nov 12, 2018
@Valodim Valodim mentioned this issue Nov 12, 2018
Closed
@clokep clokep mentioned this issue Dec 7, 2020
Open
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees
No one assigned
Labels
z-minor (Deprecated Label) z-p2 (Deprecated Label)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Valodim @neilisfragile @richvdh