Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

More specific type for detailedDiff()? #50

Open
benallfree opened this issue Nov 1, 2019 · 2 comments
Open

More specific type for detailedDiff()? #50

benallfree opened this issue Nov 1, 2019 · 2 comments

Comments

@benallfree
Copy link

benallfree commented Nov 1, 2019

Would something like this make sense? If so I can submit a PR.

export type DetailedDiffResult = {
  deleted: object;
  added: object;
  updated: object;
};

export function detailedDiff(
  originalObj: object,
  updatedObj: object
): DetailedDiffResult;
@MarkMilfordMe
Copy link

I agree this would be useful.

@FabianHummel
Copy link

Why object? This messes up the typescript. Use any instead.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants