Add Delete Method & Account for Firebase Error #14
Conversation
kulture-rob-snider
force-pushed
the
master
branch
from
8ab9a9b to
82691ed
Compare
| @@ -135,8 +135,13 @@ class FirebaseImageCacheManager { | |||
| } | |||
|
|
|||
| Future<Uint8List> remoteFileBytes( | |||
| FirebaseImageObject object, int maxSizeBytes) { | |||
| return object.reference.getData(maxSizeBytes); | |||
| FirebaseImageObject object, int maxSizeBytes) async { | |||
There was a problem hiding this comment.
Now, maxSizeBytes has no purpose and should be removed.
But really, rather than changing remoteFileBytes, consider adding an alternative method without the restriction.
Alternatively, consider keeping the object.reference.getData(maxSizeBytes) call when maxSizeBytes is specified, and doing the new logic when it isn't.
| @@ -111,6 +111,17 @@ class FirebaseImage extends ImageProvider<FirebaseImage> { | |||
| .instantiateImageCodec(await _fetchImage()); | |||
| } | |||
|
|
|||
| Future<bool> delete() async { | |||
| FirebaseImageCacheManager cacheManager = new FirebaseImageCacheManager( | |||
There was a problem hiding this comment.
Don't need the new keyword anymore.
|
Returning a transparent image should be an option (or a wrapper class), not necessarily enabled by default. In my case, I show a blurHash, then replace it with the image. If the image failed to load, I'd rather see my properly sized blurHash, not a transparent image. |
|
I feel like I should clarify that returning a transparent image will not address #11 because when the file does not exist, then the placeholder should not be replaced. Also, the proposed code catches any Exception -- there are many reasons why the image may not load. If the image does not exist, then there is nothing to load, but the load could also fail due to I/O and bad network connectivity. |
|
Thanks for the comments! I'll look to do some refactoring! |
|
I've thought about this...in my case I have a great deal of images, and I really can't constantly feed for metadata reads. So returning the transparent image is great. I just code in a stack so that my placeholder image is below the transparent or found image. Thanks for the great resource guys! |
closes #11