From 7b54bbaa3cc858de2a5d8cbdaf5b71bbc4085db7 Mon Sep 17 00:00:00 2001 From: "Dennis Ameling (he/him)" Date: Sun, 27 Nov 2022 15:11:27 -0400 Subject: [PATCH 1/3] Use updated Vale action --- .github/workflows/linting.yml | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/.github/workflows/linting.yml b/.github/workflows/linting.yml index 523c50c5..3b01da3e 100644 --- a/.github/workflows/linting.yml +++ b/.github/workflows/linting.yml @@ -1,7 +1,5 @@ name: Linting on: - # Note: onlyAnnotateModifiedLines only works correctly on PRs! - # If you need to run checks on push as well, create a separate workflow file. pull_request: jobs: @@ -14,12 +12,7 @@ jobs: fetch-depth: 0 - name: Vale - uses: errata-ai/vale-action@master - with: - # We can modify these styles as we want - styles: | - https://github.com/errata-ai/Google/releases/latest/download/Google.zip - onlyAnnotateModifiedLines: true + uses: errata-ai/vale-action@reviewdog env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} From 03c041360bf8cb7d9e02248a156c46208e55dbba Mon Sep 17 00:00:00 2001 From: "Dennis Ameling (he/him)" Date: Sun, 27 Nov 2022 15:15:42 -0400 Subject: [PATCH 2/3] Set filter_mode to nofilter --- .github/workflows/linting.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/linting.yml b/.github/workflows/linting.yml index 3b01da3e..6ea49b84 100644 --- a/.github/workflows/linting.yml +++ b/.github/workflows/linting.yml @@ -13,6 +13,8 @@ jobs: - name: Vale uses: errata-ai/vale-action@reviewdog + with: + filter_mode: nofilter env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} From dda2d3a56bfc97cdac4b1807fd7dd84846ca2eea Mon Sep 17 00:00:00 2001 From: "Dennis Ameling (he/him)" Date: Mon, 28 Nov 2022 13:06:15 -0400 Subject: [PATCH 3/3] Update Action config --- .github/workflows/linting.yml | 3 ++- .gitpod.Dockerfile | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/linting.yml b/.github/workflows/linting.yml index 6ea49b84..3899c5be 100644 --- a/.github/workflows/linting.yml +++ b/.github/workflows/linting.yml @@ -14,7 +14,8 @@ jobs: - name: Vale uses: errata-ai/vale-action@reviewdog with: - filter_mode: nofilter + # Please keep version in sync with the version in .gitpod.Dockerfile for a consistent experience + version: 2.20.2 env: GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} diff --git a/.gitpod.Dockerfile b/.gitpod.Dockerfile index 5d4224ea..fcd2e0dc 100644 --- a/.gitpod.Dockerfile +++ b/.gitpod.Dockerfile @@ -1,6 +1,7 @@ FROM python:3.10 # Don't update to a higher version until this issue has been fixed: https://github.com/errata-ai/vale/issues/528 +# Please keep version in sync with the version in .github/workflows/linting.yml for a consistent experience ENV VALE_VERSION=2.20.2 WORKDIR /workspace