Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Code refactoring is required for env_update/env.py #32

Open
arpt-svt opened this issue Oct 13, 2018 · 2 comments
Open

Code refactoring is required for env_update/env.py #32

arpt-svt opened this issue Oct 13, 2018 · 2 comments
Labels
Hacktoberfest issue-taken

Comments

@arpt-svt
Copy link
Contributor

  • Code should follow PEP8.
  • For opening the file use context management (with).
  • Change the variable name which are conflicting with python keyword.
@arpt-svt
Copy link
Contributor Author

arpt-svt commented Oct 13, 2018 •
edited
Loading

@ksatchit Hey I am taking this up.

@arpt-svt arpt-svt changed the title Code refactoring is required for env/env_exporter.py and env_update/env.py. Code refactoring is required for env/env_exporter.py. Oct 13, 2018
@arpt-svt
Copy link
Contributor Author

@ksatchit Please review this PR #33

@arpt-svt arpt-svt changed the title Code refactoring is required for env/env_exporter.py. Code refactoring is required for env_update/env.py Oct 13, 2018
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
Hacktoberfest issue-taken
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@arpt-svt @ksatchit