Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Solarized palette is inaccurate #193

Closed
antoineco opened this issue Jun 26, 2019 · 3 comments · Fixed by #194
Closed

Solarized palette is inaccurate #193

antoineco opened this issue Jun 26, 2019 · 3 comments · Fixed by #194

Comments

@antoineco
Copy link
Contributor

antoineco commented Jun 26, 2019

All Solarized themes seem to be generated from xrdb/Solarized Dark.xrbd, but the colors defined in this file are nowhere to be be found in the Solarized values reference (regardless of the issue discussed in #62/#63). This is "close enough", but inaccurate. Was this a conscious decision?

Comparison:

term color reference this repo
0 #073642 #002831
1 #dc322f #d11c24
2 #859900 #738a05
3 #b58900 #a57706
4 #268bd2 #2176c7
5 #d33682 #c61c6f
6 #2aa198 #259286
7 #eee8d5 #eae3cb
@mbadolato
Copy link
Owner

No. It's possible adjustments were made and submitted over the years but I don't know. If you'd like to submit an update to the iTerm color schemes file and submit it, we can then run the translator on it and regenerate all of the other formats

@antoineco
Copy link
Contributor Author

antoineco commented Jun 27, 2019

Ah iTerm themes are canonical, got it. 👍 Let me put that on my TODO list.

@mbadolato
Copy link
Owner

Much appreciated!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants