Skip to content

Commit d7352d6

Browse files
committed
README.md updates from bazel-contrib#1714
Also removes an extra line from the `WORKSPACE` snippet of the "Getting started" section.
1 parent e806773 commit d7352d6

File tree

1 file changed

+11
-10
lines changed

1 file changed

+11
-10
lines changed

README.md

+11-10
Original file line numberDiff line numberDiff line change
@@ -78,8 +78,6 @@ host_platform_repo(name = "host_platform")
7878
# `--incompatible_enable_proto_toolchain_resolution`.
7979
register_toolchains("@rules_scala//protoc:all")
8080

81-
host_platform_repo(name = "host_platform")
82-
8381
load("@rules_java//java:rules_java_deps.bzl", "rules_java_dependencies")
8482

8583
rules_java_dependencies()
@@ -928,22 +926,25 @@ Note that this example uses `common:` config settings instead of `build:`. This
928926
seems to prevent invalidating the action cache between `bazel` runs, which
929927
improves performance.
930928

931-
If you have another dependency that requires an earlier `protobuf` version, use
932-
the following maximum dependency versions:
929+
If you have a dependency that requires `protobuf` version before v28, use the
930+
following maximum versions of key dependencies. Note that no `ScalaPB` release
931+
supports `protobuf` v25.6, v26, or v27.
933932

934-
| Dependency | Max Bazel 6.5.0 compatible version | Reason |
933+
| Dependency | Max compatible version | Reason |
935934
| :-: | :-: | :- |
936-
| `protobuf` | v25.6 | `ScalaPB` doesn't support `protobuf` v26 or v27. |
937-
| `abseil-cpp` | 20240722.0 | Latest that works with `protobuf` v25; requires C++ compiler flags. |
935+
| `protobuf` | v25.5 | Maximum version supported by `ScalaPB` 0.11.17. |
938936
| `rules_java` | 7.12.4 | 8.x requires `protobuf` v27 and later. |
939937
| `rules_cc` | 0.0.9 | 0.0.10 requires Bazel 7 to define `CcSharedLibraryHintInfo`.<br/>0.0.13 requires at least `protobuf` v27.0. |
940-
| `ScalaPB` | 0.11.17<br/>(0.9.8 for Scala 2.11) | Supports `protobuf` < v26. |
938+
| `ScalaPB` | 0.11.17<br/>(0.9.8 for Scala 2.11) | Later versions only support `protobuf` >= v28. |
941939

942940
### `scala_proto` not supported for Scala 2.11
943941

944942
[ScalaPB 0.9.8](https://github.com/scalapb/ScalaPB/releases/tag/v0.9.8), the
945-
last version compatible with Scala 2.11, does not support `protobuf` >= v26.
946-
Since `rules_scala` now depends on a more recent `protobuf` version, we had to
943+
last version compatible with Scala 2.11, doesn't support `protobuf` v25.6 or
944+
later. See bazelbuild/rules_scala#1712 for an example of what happens to Scala
945+
2.11 test cases when using `protobuf` v25.6. Since `rules_scala` now supports
946+
more recent `protobuf` versions via [ScalaPB 1.0.0-alpha1](
947+
https://github.com/scalapb/ScalaPB/releases/tag/v1.0.0-alpha.1), we had to
947948
remove the Scala 2.11 test cases.
948949

949950
Building `scala_proto` for Scala 2.11 requires [building with Bazel 6.5.0

0 commit comments

Comments
 (0)