Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Eraser issue to erase dots #321

Open
mshahedi83 opened this issue Dec 23, 2024 · 1 comment
Open

Eraser issue to erase dots #321

mshahedi83 opened this issue Dec 23, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@mshahedi83
Copy link

mshahedi83 commented Dec 23, 2024

Lorien version:
v0.6.0
Screenshot from 2024-12-23 15-26-02

OS/device including version:
Ubuntu 20.04.6 LTS
CPU: Intel® Core™ i3-6006U CPU @ 2.00GHz × 4
GPU: NVIDIA Corporation GM108M [GeForce 920MX] - Using NVIDIA driver metapackage from nvidia-driver-470 (proprietary)
Screenshot from 2024-12-23 15-32-02

Issue description:
Hello, I'm Using Linux Ubuntu 20.04.6 and Deco Pro M pen tablet (Regular model that is not wireless.) to draw. i set Anti Aliasing Method to OpenGL Hint.

Please watch this video:

2024-12-23.15-19-03.mp4

When draw some lines, dashes and dots, and i want to erase them by Eraser, i can't erase some dots when Eraser is too large and for erase them i have to set smaller than brush size: it means larger eraser can't erase them!

another issue is the brush size isn't fixed. i mean what is show in the video, one of dashes is very larger than 8 that set for brush size!

If there are any issue, please fix it. Thank you.

Steps to reproduce:
Draw some dots with brush size 8, then set brush size to 50 and use Eraser to erase them, and then set brush size to 6 and try to erase them. (alike the video)

@tafode
Copy link
Contributor

tafode commented Jan 12, 2025

The issue is that the current eraser only checks if the stroke does intersect with the visible circle. If all points of a stroke are inside the circle, it will not be removed.

I have created a pull request, to change the logic, so that it erases the strokes also if any point is inside the circle.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants