Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove use of pp in DifferDispatcher #242

Merged
merged 1 commit into from
Apr 25, 2024
Merged

Remove use of pp in DifferDispatcher #242

merged 1 commit into from
Apr 25, 2024

Conversation

sidane
Copy link
Contributor

@sidane sidane commented Apr 25, 2024

Was causing the following output when running tests in Rails app using super_diff:

{:available_classes=>
  [SuperDiff::ActiveRecord::Differs::ActiveRecordRelation,
   SuperDiff::ActiveSupport::Differs::HashWithIndifferentAccess,
   SuperDiff::RSpec::Differs::CollectionContainingExactly,
   SuperDiff::RSpec::Differs::CollectionIncluding,
   SuperDiff::RSpec::Differs::HashIncluding,
   SuperDiff::RSpec::Differs::ObjectHavingAttributes,
   SuperDiff::Basic::Differs::Array,
   SuperDiff::Basic::Differs::Hash,
   SuperDiff::Basic::Differs::TimeLike,
   SuperDiff::Basic::Differs::DateLike,
   SuperDiff::Basic::Differs::MultilineString,
   SuperDiff::Basic::Differs::CustomObject,
   SuperDiff::Basic::Differs::DefaultObject]}

available_classes_output

Was causing the following output when running tests in Rails app
using super_diff:

```
{:available_classes=>
  [SuperDiff::ActiveRecord::Differs::ActiveRecordRelation,
   SuperDiff::ActiveSupport::Differs::HashWithIndifferentAccess,
   SuperDiff::RSpec::Differs::CollectionContainingExactly,
   SuperDiff::RSpec::Differs::CollectionIncluding,
   SuperDiff::RSpec::Differs::HashIncluding,
   SuperDiff::RSpec::Differs::ObjectHavingAttributes,
   SuperDiff::Basic::Differs::Array,
   SuperDiff::Basic::Differs::Hash,
   SuperDiff::Basic::Differs::TimeLike,
   SuperDiff::Basic::Differs::DateLike,
   SuperDiff::Basic::Differs::MultilineString,
   SuperDiff::Basic::Differs::CustomObject,
   SuperDiff::Basic::Differs::DefaultObject]}
```
@mcmire mcmire enabled auto-merge (squash) April 25, 2024 18:01
@mcmire
Copy link
Collaborator

mcmire commented Apr 25, 2024

Oops! Thank you :)

@mcmire mcmire merged commit fc346d8 into splitwise:main Apr 25, 2024
31 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants