-
-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Segment only largest finding - very useful to inpaint main face only #287
Comments
The actual impl has to be in the swarm yolo python node, but it also needs a new parameter added, probably just a Segmentation Sort Order param under Regional Prompting group to select between sort by left-right vs top-bottom vs largest-smallest |
ok so i need to modify src\BuiltinExtensions\ComfyUIBackend\ExtraNodes\SwarmComfyExtra\SwarmYolo.py and the other file name? full path please and 1 more thing. lets say i modified these files what do i need to do to make them effective without entirely restarting the application? |
|
and the workflow generator code and there's a launch-windows-dev script to apply updates. You do need a restart that's not avoidable. |
thank you from which file it will take the input?
something like this i am guessing ye i am missing more files that are used in the process for example which file translate this input and calls SwarmYolo.py |
@FurkanGozukara you're welcome! I chose to go the path mcmonkey suggested, using the params to control sorting instead of the prompt syntax. The yolo prompt syntax is already pretty heavy, and keeping it from getting more complex would be nice. The params accomplish the same thing, I think. Of note, if you use sorting, it will only return the first match after the sort. There's some room here for it to not do that. |
Feature Idea
Currently I couldn't find a way to inpaint largest face only
It also doesn't sort them from largest to smallest - this would also work
So if you can tell me which files to modify to add this feature I can also try to make a pull request
But I would appreciate very much if you had added it
Use cases
<segment:yolo-face_yolov9c.pt-largest,0.6,0.9>
or
<segment:yolo-face_yolov9c.pt-1,0.6,0.9>
- auto sorted by largest and first one inpaintedOther
No response
The text was updated successfully, but these errors were encountered: