enhance(editor): confirm before reset #2052
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caugner
force-pushed
the
1739-add-reset-confirmation
branch
from
2b4b3ea
to
be49915
Compare
caugner
changed the title
caugner
force-pushed
the
1739-add-reset-confirmation
branch
from
be49915
to
d937916
Compare
bsmth
reviewed
Nov 14, 2024
editor/js/editable-css.ts
Outdated
| @@ -95,7 +95,12 @@ import "../css/editable-css.css"; | |||
| function handleResetEvents() { | |||
| const resetButton = document.getElementById("reset") as HTMLElement; | |||
|
|
|||
| resetButton.addEventListener("click", () => { | |||
| resetButton.addEventListener("click", (event) => { | |||
| if (!window.confirm("Do you really want to reset everything?")) { | |||
There was a problem hiding this comment.
For the copy, I like wording like this:
Are you sure you want to reset the editor?
Any changes you have made will be lost.
-> OK / Cancel
bsmth
approved these changes
Nov 14, 2024
Co-authored-by: Brian Thomas Smith <brian@smith.berlin>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1739.