Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[SVG] SVG updates #11597

Closed
6 of 7 tasks
Rumyra opened this issue Dec 30, 2021 · 5 comments
Closed
6 of 7 tasks

[SVG] SVG updates #11597

Rumyra opened this issue Dec 30, 2021 · 5 comments
Assignees
Labels
Content:SVG SVG docs fx release archive A closed issue relating to firefox release notes for developers.

Comments

@Rumyra
Copy link
Collaborator

Rumyra commented Dec 30, 2021

Acceptance Criteria

  • The listed features are documented sufficiently on MDN
  • BCD is updated
  • Interactive example and data repos are updated if appropriate
  • The content has been reviewed as needed

For folks helping with Firefox related documentation

  • Set bugs to dev-doc-complete
  • Add entry to Firefox release notes if feature is enabled in release
    or
  • Add entry to Firefox experimental features page if feature is not yet enabled in release

Features to document

Couple of bugs - one is unshipping https://bugzilla.mozilla.org/show_bug.cgi?id=1388931 the other is d property https://bugzilla.mozilla.org/show_bug.cgi?id=1744599

I know some work has started in removal of SVG docs & d prop has landed on my desk before - so this should just be a case of reading through the issue & making sure docs are removed/up to date + BCD updates

NB d attr is currently in experimental features

@github-actions github-actions bot added the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Dec 30, 2021
@Rumyra Rumyra removed the needs triage Triage needed by staff and/or partners. Automatically applied when an issue is opened. label Dec 30, 2021
@hamishwillee
Copy link
Collaborator

hamishwillee commented Jan 10, 2022

For bug 1388931 I think all this needs is BCD note for SVGPathElement.getPathSegAtLength(), release note and experimental features update. There are other APS being removed but no point adding a whole file for a feature that is being removed.

Am confirming in https://bugzilla.mozilla.org/show_bug.cgi?id=1388931#c59 . For now will proceed with assumption I am correct.

TLDR is - I think it is just the following are now hidden behind dom.svg.pathSeg.enabled:

  • SVGPathSegList (including .numberOfItems, getItem() and length).
    • Not documented, but is in sidebar for SVGPathElement and also as deprecated API in Web/API/Document_Object_Model
    • This is not in BCD.
    • Do not propose to add to either as it is on the way out. But will mention in release note.
  • SVGPathElement.getPathSegAtLength()
    • Note in SVGPathElement that this was removed in SVG spec. No dedicated documented.
    • Is in BCD. Need removal
  • SVGAnimatedPathData .pathSegList and .animatedPathSegList
    • not documented in MDN.
    • not in BCD

Status

@hamishwillee
Copy link
Collaborator

hamishwillee commented Jan 11, 2022

For bug 1744599: Ship d property and make SVG path d attribute as the presentation attribute this was an experimental feature introduced in FF91 in https://bugzilla.mozilla.org/show_bug.cgi?id=1340422

Looking at this the BCD is a bit messy. We need to update the d property and the path(). There is missing spec info and it is not clear whether it is still "partial".
Other than that it looks like we need to remove experimental feature and add the release note.

@Rumyra
Copy link
Collaborator Author

Rumyra commented Jan 17, 2022

Thanks @hamishwillee - I'm keeping my eye on the BCD for this (even tho it's making my head hurt) :)

@hamishwillee
Copy link
Collaborator

Cool. I'm chasing that up. This is pretty much done/on the path to done though.

@Rumyra
Copy link
Collaborator Author

Rumyra commented Jan 31, 2022

In anticipation I'll close this :)

@Rumyra Rumyra closed this as completed Jan 31, 2022
@bsmth bsmth added fx release archive A closed issue relating to firefox release notes for developers. and removed Firefox 97 labels Dec 20, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Content:SVG SVG docs fx release archive A closed issue relating to firefox release notes for developers.
Projects
None yet
Development

No branches or pull requests

3 participants