Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(css): Update syntax for background-clip #835

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Dec 18, 2024

Description

update syntax for this property to be align with latest spec

in stable version, its syntax is defined as <visual-box>#, whcih defines support for border-box, padding-box and content-box values
in latest version, its syntax is defined as <bg-clip>#, which additional defines support for border-area and text values

per bcd, border-area value is supported by Safari and text is supported in all major platform at present

see also https://developer.mozilla.org/en-US/docs/Web/CSS/background-clip and related issue at csstree csstree/csstree#190

Motivation

Additional details

Related issues and pull requests

Takes place of #744 as the original one seems not to be working anymore

@skyclouds2001 skyclouds2001 marked this pull request as ready for review December 18, 2024 14:16
@skyclouds2001 skyclouds2001 requested a review from a team as a code owner December 18, 2024 14:16
@skyclouds2001 skyclouds2001 requested review from pepelsbey and removed request for a team December 18, 2024 14:16
Copy link
Member

@pepelsbey pepelsbey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you :)

@pepelsbey pepelsbey merged commit 76d7860 into mdn:main Dec 21, 2024
3 checks passed
@skyclouds2001 skyclouds2001 deleted the background-clip branch December 21, 2024 11:49
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants