Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

One patch! macro to rule them all #11

Open
kotauskas opened this issue Apr 3, 2020 · 1 comment
Open

One patch! macro to rule them all #11

kotauskas opened this issue Apr 3, 2020 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@kotauskas
Copy link

Currently there's the patch* functions which accept from 0 to 9 arguments, which is a limitation when it comes to a larger amount, which is surely non-idiomatic and not practical but can sometimes happen in FFI scenarios. Aside of that, the numbering just looks ugly. A patch! macro (likely implemented as a tiny separate crate decoupled from the patch guard and then reexported in the main crate because that's how proc-macro crates work) is a much cleaner way, I think.

@mehcode
Copy link
Owner

mehcode commented Apr 9, 2020

I don't disagree here. I'd be willing to accept a PR that did this.

@mehcode mehcode added enhancement New feature or request help wanted Extra attention is needed labels Apr 9, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants