Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bad behaviour when scribblong songs #2

Closed
melchor629 opened this issue Dec 30, 2018 · 0 comments
Closed

Bad behaviour when scribblong songs #2

melchor629 opened this issue Dec 30, 2018 · 0 comments

Comments

@melchor629
Copy link
Owner

Information

  • macOS version: N/A
  • App version: 0.2.3
  • Xcode version: N/A
  • Have internet connection?: N/A

Description of the issue

After the time playing the song required to scrobbler - the min(half_duration, 4 minutes) rule -, it scrobbles the song, so much that it creates the following situation:
You can see the song scrobbled and the same in the now playing in the Last.fm page.

What you expect the app should behave

the "Last.fm way" here is the scrobble is enqueued with its timestamp at the right time following the aforementioned rule, and, when the song finishes playing, it is submitted, as well as the "now playing" updated for the new song, in case there is one. (A good reference here: https://github.com/quodlibet/quodlibet/blob/b05c3fb6fcd942ddd3f5de3f34c4960c7128ec05/quodlibet/quodlibet/ext/events/qlscrobbler.py#L376)

Steps to reproduce the issue

Play any song with internet connection, and wait until the 50% of the song or 4 minutes of it.

Extra

Reported by Rui.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant