Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: SSA Delimiter Docs #1956

Merged
merged 4 commits into from
Mar 4, 2025
Merged

fix: SSA Delimiter Docs #1956

merged 4 commits into from
Mar 4, 2025

Conversation

pnadolny13
Copy link
Contributor

I ran into this today. The docs say that leaving this blank defaults to a comma but thats not true based on the code https://github.com/ets/tap-spreadsheets-anywhere/blob/0b8b905a025e394dc937324c32860c6c4b5a01d8/tap_spreadsheets_anywhere/csv_handler.py#L31

Copy link

netlify bot commented Mar 3, 2025

Deploy Preview for meltano-hub ready!

Name Link
🔨 Latest commit c323a90
🔍 Latest deploy log https://app.netlify.com/sites/meltano-hub/deploys/67c6238e60d6be0008d47a28
😎 Deploy Preview https://deploy-preview-1956--meltano-hub.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Mar 3, 2025

Testing plugin tap-spreadsheets-anywhere (ets variant):

Starting test job...
...
Job completed.

Usage info
melty-bot % tap-spreadsheets-anywhere --help
usage: tap-spreadsheets-anywhere [-h] -c CONFIG [-s STATE] [-p PROPERTIES]
                                 [--catalog CATALOG] [-d] [--dev]

options:
  -h, --help            show this help message and exit
  -c CONFIG, --config CONFIG
                        Config file
  -s STATE, --state STATE
                        State file
  -p PROPERTIES, --properties PROPERTIES
                        Property selections: DEPRECATED, Please use --catalog
                        instead
  --catalog CATALOG     Catalog file
  -d, --discover        Do schema discovery
  --dev                 Runs tap in dev mode
Detected capabilities
  • ✅ 'discover'
  • ✅ 'catalog'
  • ✅ 'state'
  • ❌ 'about'

Co-authored-by: Edgar Ramírez Mondragón <edgar@meltano.com>
@pnadolny13 pnadolny13 added this pull request to the merge queue Mar 4, 2025
Merged via the queue into main with commit d18761e Mar 4, 2025
14 checks passed
@pnadolny13 pnadolny13 deleted the pnadolny13-patch-2 branch March 4, 2025 15:49
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants