From ed088505935d005f758ebe81c711901b4cdfe3b8 Mon Sep 17 00:00:00 2001 From: Ken Payne Date: Wed, 1 Feb 2023 11:36:09 +0000 Subject: [PATCH] fix: TapDiscoveryTest remove catalog if one is passed (#1364) --- singer_sdk/testing/tap_tests.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/singer_sdk/testing/tap_tests.py b/singer_sdk/testing/tap_tests.py index 3df15c869..9128a87bf 100644 --- a/singer_sdk/testing/tap_tests.py +++ b/singer_sdk/testing/tap_tests.py @@ -34,9 +34,10 @@ def test(self) -> None: tap1 = self.tap tap1.run_discovery() catalog = tap1.catalog_dict - # Reset and re-initialize with an input catalog + # Reset and re-initialize with discovered catalog + kwargs = {k: v for k, v in self.runner.default_kwargs.items() if k != "catalog"} tap2: Tap = cast(Type[Tap], self.runner.singer_class)( - config=self.runner.config, catalog=catalog, **self.runner.default_kwargs + config=self.runner.config, catalog=catalog, **kwargs ) assert tap2