Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Do not emit log message if no record properties were ignored #1174

Merged
merged 4 commits into from
Nov 17, 2022

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Nov 11, 2022

Closes #1173


📚 Documentation preview 📚: https://meltano-sdk--1174.org.readthedocs.build/en/1174/

@edgarrmondragon edgarrmondragon force-pushed the 1173-bug-too-many-ignored-props-messages branch from 177c052 to dc8cef9 Compare November 11, 2022 18:40
@edgarrmondragon edgarrmondragon marked this pull request as ready for review November 11, 2022 18:49
@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Merging #1174 (f83fd20) into main (ca27fd5) will increase coverage by 0.06%.
The diff coverage is 100.00%.

❗ Current head f83fd20 differs from pull request most recent head 84f8fba. Consider uploading reports for the commit 84f8fba to get more accurate results

@@            Coverage Diff             @@
##             main    #1174      +/-   ##
==========================================
+ Coverage   83.60%   83.66%   +0.06%     
==========================================
  Files          42       42              
  Lines        3909     3875      -34     
  Branches      665      658       -7     
==========================================
- Hits         3268     3242      -26     
+ Misses        475      471       -4     
+ Partials      166      162       -4     
Impacted Files Coverage Δ
singer_sdk/helpers/_typing.py 52.46% <100.00%> (+2.15%) ⬆️
singer_sdk/target_base.py 86.44% <0.00%> (-0.46%) ⬇️
singer_sdk/typing.py 94.73% <0.00%> (-0.17%) ⬇️
singer_sdk/helpers/capabilities.py 91.37% <0.00%> (-0.15%) ⬇️
singer_sdk/helpers/_resources.py 100.00% <0.00%> (ø)
singer_sdk/_singerlib/__init__.py 100.00% <0.00%> (ø)
singer_sdk/sinks/sql.py 90.65% <0.00%> (+1.46%) ⬆️
singer_sdk/_singerlib/messages.py 100.00% <0.00%> (+2.38%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edgarrmondragon edgarrmondragon enabled auto-merge (squash) November 11, 2022 20:41
Copy link
Contributor

@cjohnhanson cjohnhanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@edgarrmondragon edgarrmondragon enabled auto-merge (squash) November 17, 2022 22:41
@edgarrmondragon edgarrmondragon merged commit 5b8a0be into main Nov 17, 2022
@edgarrmondragon edgarrmondragon deleted the 1173-bug-too-many-ignored-props-messages branch November 17, 2022 22:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Too many Properties () were present in the '...' stream messages
2 participants