feat: Support boolean additional_properties in JSON schema helper objects
#1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edgarrmondragon
requested review from
cjohnhanson and
aaronsteers
as code owners
edgarrmondragon
force-pushed
the
feat/boolean-additional-properties
branch
from
5dc8d0a to
dff6333
Compare
Codecov Report
@@ Coverage Diff @@
## main #1188 +/- ##
=======================================
Coverage 83.67% 83.68%
=======================================
Files 42 42
Lines 3909 3911 +2
Branches 666 667 +1
=======================================
+ Hits 3271 3273 +2
Misses 474 474
Partials 164 164
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
edgarrmondragon
requested review from
kgpayne
and removed request for
cjohnhanson
|
Low risk, quick win. Merging. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a smaller incremental change extracted from #768
📚 Documentation preview 📚: https://meltano-sdk--1188.org.readthedocs.build/en/1188/