perf: Improve performance of record message serialization #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jack-Burnett
requested review from
edgarrmondragon,
cjohnhanson and
aaronsteers
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1196 +/- ##
==========================================
- Coverage 83.58% 83.56% -0.03%
==========================================
Files 42 42
Lines 3874 3881 +7
Branches 657 659 +2
==========================================
+ Hits 3238 3243 +5
- Misses 473 474 +1
- Partials 163 164 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
edgarrmondragon
changed the title
edgarrmondragon
approved these changes
Nov 16, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my testing, taps spend about half of their time converting record messages to dicts. This basically reduces that to nothing, doubling the throughput of the average tap.
Closes #1194
📚 Documentation preview 📚: https://meltano-sdk--1196.org.readthedocs.build/en/1196/