Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat(taps): Catch and retry ConnectionResetError exceptions in HTTP taps #1237

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Dec 2, 2022

Closes #1236


📚 Documentation preview 📚: https://meltano-sdk--1237.org.readthedocs.build/en/1237/

@codecov
Copy link

codecov bot commented Dec 2, 2022

Codecov Report

Merging #1237 (56e15d1) into main (cf51acc) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1237   +/-   ##
=======================================
  Coverage   83.72%   83.72%           
=======================================
  Files          42       42           
  Lines        3909     3909           
  Branches      665      665           
=======================================
  Hits         3273     3273           
  Misses        473      473           
  Partials      163      163           
Impacted Files Coverage Δ
singer_sdk/streams/rest.py 84.90% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@edgarrmondragon edgarrmondragon marked this pull request as ready for review December 2, 2022 22:15
@edgarrmondragon edgarrmondragon changed the title feat: Catch and retry ConnectionResetError exceptions in HTTP taps feat(taps): Catch and retry ConnectionResetError exceptions in HTTP taps Dec 2, 2022
@edgarrmondragon edgarrmondragon merged commit 18aca68 into main Dec 2, 2022
@edgarrmondragon edgarrmondragon deleted the 1236-feature-automatically-retry-connectionreseterror-in-rest-and-graphql-taps branch December 2, 2022 23:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Automatically retry ConnectionResetError in REST and GraphQL taps
2 participants